New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get assertion when signature reference URI is empty #264

Open

toopy wants to merge 2 commits into SAML-Toolkits:master from peopledoc:get-assertion-when-signature-reference-URI-is-empty-contrib

Contributor

toopy commented Jun 21, 2021

As reproduced in the test of this PR, we can have an empty reference URI, but a valid signature response with the nameID value.

toopy added 2 commits

June 21, 2021 16:10


          Test assertion when signature reference URI is empty

946c53c


          Get assertion when signature reference URI is empty

f04950d

pitbulk added the enhancement label

Contributor

pitbulk commented Jan 28, 2022

On this thread Scott Cantor says that empty URIs shouldn't be allowed in SAML implementations
http://shibboleth.net/pipermail/dev/2016-April/008162.html

pitbulk added wontfix informative labels

pitbulk force-pushed the master branch 2 times, most recently from 4fa3934 to acef8eb Compare

December 26, 2022 01:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement informative wontfix